This repository was archived by the owner on May 15, 2026. It is now read-only.
fix: execute_command UI now accurately shows terminal state - #11048
Draft
ghost wants to merge 1 commit into
Draft
Conversation
EXT-672: The execute_command UI now accurately shows the terminal state: - Shows "Running" when a command is actively executing - Shows "Executed" when the command has completed Added "executed" translation key to all 18 locale files.
Author
Review completed. No issues found. The PR correctly aligns the command execution title text with the existing icon state logic. The Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes EXT-672: The execute_command UI now accurately shows the state of the terminal session.
Problem
The execute_command UI always showed "Running" regardless of whether the command was still executing or had already completed. The icon would change (spinner vs terminal icon), but the text never reflected the actual state.
Solution
Modified ChatRow.tsx to show:
Added the "executed" translation key to all 18 locale files with appropriate translations.
Changes
webview-ui/src/components/chat/ChatRow.tsx- Conditional title based onisCommandExecutingwebview-ui/src/i18n/locales/*/chat.json- Added "executed" key to all localesView task on Roo Code Cloud
Important
Fixes execute_command UI to accurately display "Running" or "Executed" based on command state in
ChatRow.tsx, with localization updates.ChatRow.tsxnow conditionally displays "Running" or "Executed" based onisCommandExecuting.ChatRow.tsxupdated for conditional text display.locales/*/chat.jsonupdated with "executed" key.This description was created by
for c3f23c5. You can customize this summary. It will automatically update as commits are pushed.